Skip to content

Commit

Permalink
feat: stringify object values (#24)
Browse files Browse the repository at this point in the history
Fixes RM-2228
:---:

## 🧰 What's being changed?

Allow using objects as variable values.
  • Loading branch information
kellyjosephprice authored Sep 17, 2021
1 parent ae8e8b6 commit 1936d63
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions __tests__/index.test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ describe('single variable', () => {
});

it.todo('should set `selected` if nothing is selected');

it('should render objects as strings', () => {
const variable = shallow(<Variable {...props} user={{ apiKey: { renderTo: 'string' } }} />);

expect(variable.text()).toBe(JSON.stringify({ renderTo: 'string' }));
});
});

describe('multiple variables', () => {
Expand Down
4 changes: 2 additions & 2 deletions index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ class Variable extends React.Component {
// - uppercase key
getValue() {
const { variable } = this.props;
if (this.props.user[variable]) return this.props.user[variable];
const value = this.props.user[variable] || this.getDefault();

return this.getDefault();
return typeof value === 'object' ? JSON.stringify(value) : value;
}

toggleVarDropdown() {
Expand Down

0 comments on commit 1936d63

Please sign in to comment.