Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding highlight support for graphql #173

Merged
merged 1 commit into from
Sep 17, 2021
Merged

feat: adding highlight support for graphql #173

merged 1 commit into from
Sep 17, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Sep 17, 2021

🧰 What's being changed?

This pulls in codemirror-graphql to allow for us to highlight GraphQL.

🧪 Testing

I didn't commit this change to the local server demo, but this is highlight in action:

Screen Shot 2021-09-17 at 2 22 05 PM

@erunion erunion added the enhancement New feature or request label Sep 17, 2021
mjcuva
mjcuva approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@mjcuva mjcuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk how to test, but the code all seems good to me!

@erunion erunion merged commit 8ffcb52 into main Sep 17, 2021
@erunion erunion deleted the feat/highlight-graphql branch September 17, 2021 23:13
@erunion erunion mentioned this pull request Sep 17, 2021
Merged
kellyjosephprice pushed a commit to readmeio/markdown that referenced this pull request Sep 20, 2021
@erunion
chore(deps): bumping syntax-highlighter to support graphql (#309)
c38ba00 
[<img height=20 src=https://readme.com/static/favicon.ico align=center>][demo] |
:---:|

## 🧰 Changes

This bumps `@readme/syntax-highlighter` to allow for us to start highlighting GraphQL code. Available code language modes (the language that comes after the 3 backticks) that we'll support are `graphql` and `gql`.

## 📚 Release Notes
### 10.13.0 (2021-09-17)

* docs: adding a code of conduct ([41d91b5](readmeio/syntax-highlighter@41d91b5))
* feat: adding highlight support for graphql (#173) ([8ffcb52](readmeio/syntax-highlighter@8ffcb52)), closes [#173](readmeio/syntax-highlighter#173)


[demo]: https://markdown-pr-309.herokuapp.com
[prod]: https://rdme.readme.io
@kanadgupta kanadgupta mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcuva mjcuva mjcuva approved these changes

@rafegoldberg rafegoldberg Awaiting requested review from rafegoldberg

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @mjcuva