feat: upgrading our builds to use webpack 5 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
erunion
commented
Sep 16, 2021
| @@ -99,37 +99,6 @@ ReactDOM.render( | |||
| </cmVariableContext.Provider> | |||
| </pre> | |||
|
|
|||
| <h2>Custom Theme: tomorrow-night</h2> | |||
There was a problem hiding this comment.
Removed this from the demo page because tomorrow-night isn't being loaded within the library (because it's a custom theme) so the styles on these were always jank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
There's been a lot of security issues with Webpack@4 that have been clogging up
npm auditso I've decided to finally rip the bandaid off and upgrade us here.🧪 Testing
npm buildwork?npm startand play around with the little demo in the browser?