Skip to content

Commit

Permalink
feat: loosening up the npm engine requirements to easily allow npm@8 (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
erunion authored Dec 14, 2021
1 parent 1c872fd commit d5d44b3
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 88 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,21 @@ on: [push]
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x, 16.x]

steps:
- uses: actions/[email protected]

- uses: actions/[email protected]
with:
node-version: 14.15.1
node-version: ${{ matrix.node-version }}

# Node 16 still ships with npm@8 so for compatibility reasons we're upping this for everything else.
- name: Install npm@8
if: matrix.node-version != '16.x'
run: npm install -g npm@8

- run: npm install -g npm@7
- run: npm ci
- run: npm test
85 changes: 1 addition & 84 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"url": "[email protected]:readmeio/eslint-config.git"
},
"engines": {
"node": "^12 || ^14",
"npm": "^7"
"node": "^12 || ^14 || ^16"
},
"scripts": {
"prepare": "husky install",
Expand Down

0 comments on commit d5d44b3

Please sign in to comment.