Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.76] Fix errors with component stacks reported as warnings #560

Closed
huntie opened this issue Oct 4, 2024 · 5 comments
Closed

[0.76] Fix errors with component stacks reported as warnings #560

huntie opened this issue Oct 4, 2024 · 5 comments

Comments

@huntie
Copy link
Member

huntie commented Oct 4, 2024

Target Branch(es)

0.76

Link to commit or PR to be picked

facebook/react-native#46637

Description

This is a desirable (although optional) pick request that changes the default behaviour of LogBox.setWarningFilter(), which could lead to confusing behaviour when combined with React Native DevTools changes around LogBox.

PRs (originally to main) to pick in order:

(⬆️ If needed, changes could be more granularly selected, but I don't anticipate conflicts in this section of the codebase.)

@blakef blakef moved this from Inbox to Done / Picked in React Native 0.76 Releases Oct 7, 2024
@blakef blakef closed this as completed by moving to Done / Picked in React Native 0.76 Releases Oct 7, 2024
@blakef
Copy link
Collaborator

blakef commented Oct 7, 2024

I'm reverting these from RC4, the unit tests are unfortunately failing: https://github.com/facebook/react-native/actions/runs/11217965745/job/31180674552#step:3:766

@blakef blakef reopened this Oct 7, 2024
@blakef blakef moved this from Done / Picked to Inbox in React Native 0.76 Releases Oct 7, 2024
@blakef
Copy link
Collaborator

blakef commented Oct 28, 2024

@huntie we're skipping this for 0.76.1 because nothing has changed (so we think the tests will continue to fail). If you think this should go in 0.76.2, please update so it'll pass CI.

@huntie
Copy link
Member Author

huntie commented Oct 30, 2024

Ugh 👍🏻. I'll recreate a single PR without the tests (covered on main).

@blakef
Copy link
Collaborator

blakef commented Oct 30, 2024

Use #607 to track.

@blakef blakef closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done / Picked in React Native 0.76 Releases Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done / Picked
Development

No branches or pull requests

2 participants