-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align counter example code with Effect dependencies documentation #7346
base: main
Are you sure you want to change the base?
Conversation
The original code didn't work well. The new implementation better matches the tutorial text explaining why suppressing dependency checks is dangerous and ensures the counter works as intended.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @Windyskr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Thank you! We will now be able to accept any pull requests that you make to projects on our GitHub account. If you already submitted a pull request before signing the CLA, then we will add a confirmation comment on that pull request (this might take several minutes). If you haven't submitted a pull request yet, then we look forward to your future contributions! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
The original code didn't work properly - the counter only incremented once and then stopped. It failed to demonstrate the tutorial's point about dependency warnings.
After changes, the counter now increments every second, but remains unresponsive to button clicks, which suppressing the dependency linter so dangerous.