Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align counter example code with Effect dependencies documentation #7346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Windyskr
Copy link

The original code didn't work properly - the counter only incremented once and then stopped. It failed to demonstrate the tutorial's point about dependency warnings.
After changes, the counter now increments every second, but remains unresponsive to button clicks, which suppressing the dependency linter so dangerous.

The original code didn't work well. The new implementation better matches the tutorial text explaining why suppressing dependency checks is dangerous and ensures the counter works as intended.
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 7:01am
react-dev ✅ Ready (Inspect) Visit Preview Dec 10, 2024 7:01am

@facebook-github-bot
Copy link
Collaborator

Hi @Windyskr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Windyskr
Copy link
Author

Thank you!
Thank you for taking the time to register as an open source contributor. You may print the submission below for your records. You can resubmit this form to update your name or email. If you would like to make any other changes, please email [email protected] with your details.

We will now be able to accept any pull requests that you make to projects on our GitHub account. If you already submitted a pull request before signing the CLA, then we will add a confirmation comment on that pull request (this might take several minutes). If you haven't submitted a pull request yet, then we look forward to your future contributions!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants