-
Notifications
You must be signed in to change notification settings - Fork 224
feat: add keyboardHidesTabBarAnimationConfig props #195
feat: add keyboardHidesTabBarAnimationConfig props #195
Conversation
Thanks for the PR. I'd rather have something like |
Noted. So i think there will be 2 configs for animations show and hide. What do you think @satya164 ? |
I think we can make it an object with show/hide properties. We could have default value for both and shallow merge. |
Yeah, will update the PR |
just updated the config, but its only support edit: |
after giving a thought, i guess
What do you think @satya164 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, I was on holidays. Yeah we should support other animations as well (for example spring is a valid animation), but in that case, duration
isn't a valid config. So we'd need to check the type of animation and add default duration only for timing.
The type definitions also need to be updated.
@satya164 Just updated the PR
|
Hi @satya164 , any suggestion or concern regarding the new updates? |
Thanks for the updates! |
Motivation
Fixes #149
Add
keyboardHidesTabBarAnimationConfig
onTabBarOptions
to modify keyboard animationTest plan
Use this config as
TabBarOptions
: