This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
feat: hide tab bar when keyboard is shown #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
reviewed
Mar 29, 2019
| ], | ||
| // Absolutely position the tab bar so that the content is below it | ||
| // This is needed to avoid gap at bottom when the tab bar is hidden | ||
| position: this.state.keyboard ? 'absolute' : null, |
There was a problem hiding this comment.
by absolutely positioning the tab bar does this mean that screens inside of the tabs need to account for the height of the tabbar, eg: with bottom scroll insets?
There was a problem hiding this comment.
@brentvatne this is only when the keyboard is open, the tab bar will translate down and hide, so there's no need to account for it.
brentvatne
approved these changes
Mar 30, 2019
|
very cool 😎 |
satya164
force-pushed
the
@satya164/keyboard-tab-view
branch
from
b8c2199 to
9548fa2
Compare
satya164
added a commit
that referenced
this pull request
Apr 1, 2019
Closes #16 When the statusbar is not translucent, the view resizes when the keyboard is shown on Android. The tab bar stays above the keyboard. This PR makes the tab bar hide automatically when the keyboard is shown. The behaviour is enabled by default and can be disabled with `keyboardHidesTabBar: false` in `tabBarOptions`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
When the statusbar is not translucent, the view resizes when the keyboard is shown on Android. The tab bar stays above the keyboard. This PR makes the tab bar hide automatically when the keyboard is shown.
The behaviour is enabled by default and can be disabled with
keyboardHidesTabBar: falseintabBarOptions