0.61.0 Discussion

[grabbou]

Conversations on this thread are limited to 0.61 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.0 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[tomtargosz]

Can we get facebook/react-native@a4fbb8e included? Currently In iOS 13 apps will crash if more than one action is performed on a Sharesheet.

[thymikee]

facebook/react-native@9f0dede - fix for Gesture Handler, affecting React Navigation

[satya164]

We should also revert facebook/react-native@d57cdac and facebook/react-native@3e4c5c0

Context: https://twitter.com/joelafiosca/status/1176731298007851009?s=20

[grabbou]

Cherry-picking facebook/react-native@9f0dede that must have been skipped by a mistake. The facebook/react-native@a4fbb8e also sounds like a quick and helpful fix, including it as well.

--

@satya164,

We should also revert facebook/react-native@d57cdac and facebook/react-native@3e4c5c0

It seems to be an issue with the Bitrise, not React Native itself (no issues running iOS with XCode). According to the StackOverflow issue mentioned in the linked tweet:

Committing this file to source control will prevent unnecessary rerunning of those checks for each user opening the workspace. (37293167)

It doesn't mean it is required. I would like to get additional context on this commit from the @karanjthakkar and @hramos and whether they were aware of this.

[satya164]

@grabbou according to the linked tweet, CIs like bitrise expect this file to be present. people can add it manually when they need, but imo there's no harm in keeping it if it can make it few cases easier.

[grabbou]

I am with you on that @satya164.

Is the best solution to remove it from the template's .gitignore so that it is by default present when people commit to Git repository?

I don't think it has to be present by_default if it's automatically generated anyway

[grabbou]

I have reverted them both. Shipping 0.61.1 right now.