Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.58.6 Discussion #97

Closed
kelset opened this issue Feb 28, 2019 · 2 comments
Closed

0.58.6 Discussion #97

kelset opened this issue Feb 28, 2019 · 2 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@kelset
Copy link
Member

kelset commented Feb 28, 2019

Conversation on this thread are limited to 0.58.6 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.6 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

In this particular scenario, we actually won't publish a 0.58.7 release unless major issues appear: we are getting close to the 0.59.0 stable status so we prefer to focus on that - you can keep up to date about it here.

@kelset kelset added stable Stable version backport request Cherry picking a change into an existing release labels Feb 28, 2019
@retyui
Copy link

retyui commented Mar 6, 2019

Why you don't upgrade Flow.js?

https://github.com/facebook/react-native/blob/7da864284997109a37bbef739289c5e6e8d0514e/.flowconfig#L101

@grabbou
Copy link
Member

grabbou commented Mar 12, 2019

We have just released 0.59.0 stable. That means we no longer provide cherry-picks to 0.58.x versions.

@grabbou grabbou closed this as completed Mar 12, 2019
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests

3 participants