-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renewed Path to React Navigation V1.0 #2585
Comments
@matthamil fantastic — thanks for the update, and looking forward to the post. Feel free to take this as a comment, but I’d really like to see (and would be interested in contributing) a more robust, integration level set of tests to this library. Examples are good, but are not the right tool to prove functionality and prevent regressions—especially as the collaborators attempt to tackle the above roadmap... I would strongly urge you to tackle this as a matter of priority as it will make the project as a whole more accessible and reliable. ❤️ |
Tabs connected to Redux on android very slow. Please add it fix in Roadmap. |
Do you have an open issue for this problem @allmaxgit? |
@matthamil any chance this guy can be looked into as part of the roadmap? #1493 |
Dynamic routes and/or options for Because for example, there are ways to show less tabs than there are screens, by using a custom |
What do you think about improving Android transitions? They are totally off right now comparing to native. See #726. |
I would love if we could actually fix Flow types for The issue is that a stock React Native app with Flow enabled will have dozens of Flow errors once you install and require I really think 1.0 should be able to install on a stock React Native app without any Flow errors. |
From reviewing our code looking for our hacky solutions. I make this list with the workarounds we believe shall be covered by the lib:
And my personal advice:
About the roadmap to v1. IMHO, I feel like it's too ambitious. The current state of the issue's list is very prone to fail cause overwhelm. Can we think about break it into smaller milestones? |
See this comment for a sum up of another suggestions thread #2031 (comment) (note these are more general/abstract) Copy of the list here
|
@matthamil Could you fix the Reactiflux link? It's broken. |
@hysan Done, thanks for catching that. |
What are your plans for web support? |
@matthamil #1313 and #2400 are not exactly related to idempotent pushes. These two are much more severe bugs than that :) I opened #2334 for idempotent pushes which, IMO, it's a better solution than #2578 because it's not a time based solution and allows an optional key to be passed in case you want to push the same screen. It also fixes some of the GO BACK issues |
I'd like to help fix these issues, though that is just pending our client giving the ok to work on them and react-navigation's maintainers not bothering to finish reviewing my PR(s). |
@dantman see #2476 (comment). With this new team of awesome people, we should be able to get to your PRs in a reasonable amount of time :). Thank you for your contributions |
Ok. @matthamil you reviewed #1313 and I made the changes you requested, it's been unreviewed since then. Could you or someone else re-review it? |
@matthamil Will roadmap fixes be released as they are completed (beta-13, beta-14, beta-15...) or will we have to wait for a full v1 release? |
Would like to ask same question as @necolas did. In my opinion, navigation on web and mobile differs so greatly, it's not even possible to reuse navigation logic. Mobile apps does not share layouts with web apps - web apps often do more work on single screen than mobile counterparts. While navigation library could support both environments, the question is whether it should. Edit: how about declarative config? #2546 |
Depends on "desktop" or "mobile web" (eg: twitter like)... |
Fair point here, but I still think web based twitter does more job per screen than on mobile. |
@lucianomlima I'd like to see versions released with each update. Unless an improvement or feature doesn't make sense to be released by itself. To answer @necolas and @Andreyco , I don't speak for every collaborator, but I believe that web support in react-navigation is not a priority for 1.0. The web support for react-navigation is very experimental currently, and there is plenty of work already to be done for mobile navigation. However, we'll gladly accept a PR that helps add web support. I'd love to see web support eventually. |
I see, maybe it would be best to drop mention of web support for now? A lot of people incorrectly assume this library will work on web or with react-native-web. |
Yep, I agree web support should not be priority for It's extremely crucial to get mobile navigation right! :) |
Concerning web, it doesn't seem to slow down the project: if you search for |
Discussing whether support for web is useful based on whether |
Discussion of dropping/retaining web support for react navigation should probably be moved to a separate issue so we can keep this discussion focused on the v1 roadmap. I think the majority can agree that react navigation's v1 roadmap should focus only on native, considering this library is called out as the recommended navigator for react native. |
A lot of people "incorrectly" assume this library will work on the web because on docs site it says: "Share navigation logic between mobile apps, web apps, ..." or "Learn once, navigate anywhere" on GitHub. There are web projects that use this and depend on it because docs say it can be used on the web. |
I have lots of thoughts, but since there's already a lot on the table here, I'm only going to list my number one:
|
@joncursi I think you sort of misunderstood my comment about performances you are referring to; what I mean there is that the "low-hanging fruit" resides outside the lib itself but in the Components' code written by developers. Improving perfs is surely something we want to work on but it may be quite complicated. |
@matthamil I think the Circular Reference Issue in StackNavigator we spoke about earlier is also an important unresolved part of this library. If you look at the labels added by @satya164 it becomes pretty obvious that it should be part of the library. I don't know enough to fix it myself with a PR but I know it's pretty important to bring it up in this thread for a possible fix :) Thoughts? |
Please add this feature #2659 it would be a great help, thanks. |
Is it possible to add the pending PRs related with the open issues?? |
@matthamil check "Allow multiple Drawers #780" |
Thanks, fixed @stereodenis :) |
Any chance taking a look on #2390 ? |
Quick update guys, a lot of reinforcements arrived - and they will do some heavy lifting in the next few weeks - so if releases get bolder and crazier don't panic, it's because we are aiming for 1.0 for end of Q1. |
Huge shout-out to everyone who contributed to get this library to 1.0! 😄 https://reactnavigation.org/blog/2018/02/06/react-navigation-1.0.html |
Thank you to all that made this happen ! |
A (Renewed) Path to React Navigation V1
Blog post about the new roadmap. The blog post introduces the many awesome community members who have stepped up to revitalize this project.Below lists the updated roadmap to 1.0 for react-navigation. The roadmap has been updated to include issues that received positive feedback from the community. For reference, the old roadmap can be found here.
Renewed Roadmap to 1.0
Resolved issues from original roadmap:
header
configurable #1220Look at this later
How can you help?
We need your help to reach 1.0. For the time being, we will be prioritizing PRs that help the community reach 1.0.
There are many ways to contribute without writing a PR:
Ultimately, the path to 1.0 will take time. We hope to quickly bring the library up to speed again.
The text was updated successfully, but these errors were encountered: