Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the unmaintained/outdated react-google-maps dependency #23

Open
rideyourstyle opened this issue Apr 27, 2020 · 5 comments
Open

Comments

@rideyourstyle
Copy link

Are there any intentions to replace the unmaintained (react-google-maps) dependency with a maintainend one?

The package @react-google-maps/api is a maintained one, based on react-google-maps.

When I use the react-location-picker with react 16.13.1 we have some deprecation warnings. That's also the reason why we moved from react-google-maps (last commit 2 years ago) to @react-google-maps/api

@rameshsyn
Copy link
Owner

@rideyourstyle Thanks for raising the issue. Didn't know about the @react-google-maps/api. Yes, I want to replace it. Would you mind sending a PR replacing the react-google-maps package? seems like you already have experience with it. react-location-picker only uses a few components from react-google-maps, so it shouldn't take time replacing it.

@rideyourstyle
Copy link
Author

I will give it a try. I have no expirience with "modules" but it seems possible to replace it ;-)

@rameshsyn
Copy link
Owner

@rideyourstyle 👍

@rideyourstyle
Copy link
Author

rideyourstyle commented Apr 29, 2020

Done #24 :-)
The replacemant itself was easy, but it was the first time I work on a compiled lib.
I added also mapOptions to modify the map.

Because componentWillReceiveProps causes deprecation warnings, I will replace it in my fork.

@rideyourstyle
Copy link
Author

I think I can close this PR, because there will be way more issuses with this librarie(s) in the meantime...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants