Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract revert error messages are too vague #1423

Open
jxom opened this issue Mar 22, 2024 · 3 comments
Open

Contract revert error messages are too vague #1423

jxom opened this issue Mar 22, 2024 · 3 comments

Comments

@jxom
Copy link
Contributor

jxom commented Mar 22, 2024

When a contract interaction is expected to revert, I would expect the primary action to be disabled and a proper error message (from revert data) to be displayed (for this case "Token ID is taken"):

CleanShot 2024-03-22 at 13 09 29@2x

Can repro by performing mint(69) on https://etherscan.io/address/0xFBA3912Ca04dd458c843e2EE08967fC04f3579c2#writeContract.
@jxom
Copy link
Contributor Author

jxom commented Mar 25, 2024

I'll be right thanks

@jxom
Copy link
Contributor Author

jxom commented Mar 25, 2024

Yeah, I managed to get in touch with the Senior Customer Success Manager (Wallet Team) at Ethereum. They are very helpful and deserve a pay rise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jxom and others