Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss Function - Not the PCF? #56

Open
JonStevensWork opened this issue Apr 18, 2019 · 2 comments
Open

Loss Function - Not the PCF? #56

JonStevensWork opened this issue Apr 18, 2019 · 2 comments

Comments

@JonStevensWork
Copy link

Hello, when looking at the likelihood function for the Weibull, I derived a different function than you do. Here is your function:

loglikelihoods = censored * (K.log(shape) + shape * K.log(x)) - K.pow(x, shape)

However when I do this, I end up with a K.log(scale) term as well. Can you explain how you arrived at your loglikelihood function? I can provide my working if necessary

@michael-tsel
Copy link

Totally agree, made a pull request

@ragulpr
Copy link
Owner

ragulpr commented Oct 13, 2019

Hi there, thanks for contributing! I added some comments on PR #59

Otherwise I recommend reading

Proposition 2.26 and chapter 3.1.1 and 3.2 in particular shows some alternative forms of the loss function. http://publications.lib.chalmers.se/records/fulltext/253611/253611.pdf

Is there any qualitative difference to the current form? I'd be happy to see how you arrived at your definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants