Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: use /oauth/userinfo and respect GITLAB_URL #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gartnera
Copy link

Gitlab supports the standard /oauth/userinfo oauth/odic endpoint so we should use that instead of gitlab specific API calls.

Also allow setting the gitlab url via environment variable. Still defaults to https://gitlab.com.

Also set DefaultScopes correctly. Users should be instructed to grant their gitlab app to grant the following scopes: email openid

Closes #118

@coveralls
Copy link

coveralls commented May 19, 2019

Coverage Status

Coverage increased (+0.3%) to 91.682% when pulling d9e8166 on gartnera:master into b759a6a on tarent:master.

@matfiz
Copy link

matfiz commented Jun 10, 2019

@smancke it would be so great if you could find a moment to review and merge this to master in the nearest future.

@xadereq
Copy link

xadereq commented Jul 16, 2019

@smancke bumping request above ^

@gamalan
Copy link

gamalan commented Sep 2, 2019

definitely need this

@gartnera
Copy link
Author

Test failure is unrelated.

amd64 build of caddy is located here: https://gitlab.com/gartnera/caddy-gitlab-login/-/jobs

@g-w
Copy link
Contributor

g-w commented Dec 9, 2019

Hello @gartnera,
could you please rebase your PR to the current master. After that I will have a look into your changes and merge them.

@xadereq
Copy link

xadereq commented Feb 5, 2020

Hello @gartnera,
could you please rebase your PR to the current master. After that I will have a look into your changes and merge them.

@g-w Looks like it's rebased, could you take a look at it? It's been almost a year..

@xadereq
Copy link

xadereq commented Mar 31, 2020

Well, it looks like COVID-19 will eventually finish our living in misery faster than you making decision about merging this PR. Bumping...

@g-w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self hosted gitlab
6 participants