Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@room notifications #107

Open
KitsuneRal opened this issue Oct 29, 2017 · 1 comment
Open

@room notifications #107

KitsuneRal opened this issue Oct 29, 2017 · 1 comment
Labels
enhancement A feature or change request for the library good first issue Looks easy to fix, a good first issue

Comments

@KitsuneRal
Copy link
Member

While a naïve implementation would be dead simple (just add @room to the highlight-setting logic mentioned in #106), the proper implementation should follow the spec and Synapse/Riot behaviour described in the respective Google Doc. This implies dependency on #36 in the part of power_levels.

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Oct 29, 2017
This was referenced Feb 11, 2019
@KitsuneRal
Copy link
Member Author

Now that power level events are a thing in the library, implementing this becomes as simple as checking whether the message (non-HTML) body contains @room and if it does, marking it for highlighting if and only if the event sender has the power level equal to or higher than that stated in the power level event (as returned by RoomPowerLevelsEvent::roomNotifications()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library good first issue Looks easy to fix, a good first issue
Projects
Status: 0.9 - To Do
Development

No branches or pull requests

1 participant