Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retransmit path_abandon on another path #473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mirjak
Copy link
Collaborator

@mirjak mirjak commented Dec 3, 2024

fixes #470

Copy link
Contributor

@qdeconinck qdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this text is really needed, but I am not against some examples.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
Thanks

Co-authored-by: Quentin De Coninck <[email protected]>
Copy link
Contributor

@yfmascgy yfmascgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is that It may not be necessary to include this level of detail here. multipath QUIC, as a reliable protocol, will inherently address frame loss, and the decision on how best to handle it—including on which path to retransmit—should be guided by the path scheduler. But I do like the fact that the loss of path_abandon could hurt performance and is called out here.

@huitema
Copy link
Contributor

huitema commented Dec 8, 2024

I agree with @yfmascgy. This is a general issue, not specific to path abandon. We don't need more text.

@mirjak
Copy link
Collaborator Author

mirjak commented Dec 10, 2024

For sure this text is not necessarily needed but I think having a PTO for the path_abandon frame is an important case and therefore pointing this out could people help to get at least this case right. But I have no strong opinion. I think the question is would it potentially help implementors?

@qdeconinck
Copy link
Contributor

qdeconinck commented Dec 13, 2024

I agree with the majority here and still stick with my original opinion that this text is not really needed (or at least not there). We may add something in the implementation considerations regarding the scheduling and the potential performance issues we may have -- though again, I would not fight to have such text in the draft.

@huitema
Copy link
Contributor

huitema commented Dec 14, 2024

I do not think that additional text would help implementers. We have to assume that people implementing a complex real-time transport protocol have sufficient skills and exercise judgment. Piling up extra text leads to generally increasing the size of the document -- maybe one paragraph at a time, but it does add up. And then we have the next issue: making the document so large that implementers shudder at the idea of reading it all.

Also, let me reiterate that we have very little operational experience. We can make recommendations, but they are based on that limited experience. When there are lots of possible valid strategies, it might be better to say nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend that PATH_ABANDON should be retransmitted on another path
5 participants