Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner quicksilver/app #169

Closed
Anmol1696 opened this issue Aug 5, 2022 · 1 comment · Fixed by #307
Closed

Cleaner quicksilver/app #169

Anmol1696 opened this issue Aug 5, 2022 · 1 comment · Fixed by #307
Assignees
@aljo242

Comments

@Anmol1696
Copy link

Anmol1696 commented Aug 5, 2022 •
edited
Loading

Overview

Although this is before the launch, it would be best to be able to deal with upgrades and make app.go more moduler.

Problem Definition

app/app.go will become too big file.

Proposal

  • split app/app.go into app.go, upgrade/, keepers/ , module.go
  • app_test.go into apptest/app_test.go

ref:
Gaia issue: cosmos/gaia#1557
osmosis/app
provenance/app
@Anmol1696
Copy link
Author

Would be happy to contribute, if there is any interest on this

@aljo242 aljo242 assigned aljo242 and unassigned aljo242 Feb 16, 2023
@aljo242 aljo242 mentioned this issue Feb 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aljo242 aljo242

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: simplify quicksilver/app quicksilver-zone/quicksilver
2 participants
@Anmol1696 @aljo242