Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding of Server Initials fails if the certifictate is very small #2875

Closed
marten-seemann opened this issue Nov 14, 2020 · 0 comments · Fixed by #2876
Closed

padding of Server Initials fails if the certifictate is very small #2875

marten-seemann opened this issue Nov 14, 2020 · 0 comments · Fixed by #2876
Assignees
Labels

Comments

@marten-seemann
Copy link
Member

If the certificate is very small, the first packet will contain an Initial, Handshake and 1-RTT packet. This will cause a problem cause by padding the Initial, which we introduced in #2840.

In this case, we can't pad by appending 0s to the end of the packet, as the 1-RTT packet doesn't have a length field and always extends to the end of the packet. This will lead to the first packet ending up undecryptable for the client.

Unfortunately, the congestion controller on the server will notice this: As the the first packet is never acknowledged, the server will declare it lost, and start the connection in recovery. This is bad for throughput.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant