diff --git a/.github/workflows/all_checks_osmosis.yml b/.github/workflows/all_checks_osmosis.yml index 38f1c798f..02d860e5b 100644 --- a/.github/workflows/all_checks_osmosis.yml +++ b/.github/workflows/all_checks_osmosis.yml @@ -3,6 +3,10 @@ name: Test Tube (osmosis) on: workflow_call: inputs: + unittest: + required: false + default: false + type: boolean proptest: required: false default: false @@ -26,7 +30,7 @@ jobs: - name: Install Rust uses: dtolnay/rust-toolchain@stable - name: Cleanup runner - run: sudo rm -rf /usr/local/share/boost && sudo rm -rf /usr/share/dotnet && sudo rm -rf /usr/local/lib/android && sudo rm -rf /opt/ghc && sudo rm -rf /opt/hostedtoolcache/CodeQL && sudo docker image prune --all --force + run: sudo rm -rf /usr/local/share/boost && sudo rm -rf /usr/share/dotnet && sudo rm -rf /usr/local/lib/android && sudo rm -rf /opt/ghc && sudo rm -rf /opt/hostedtoolcache/CodeQL && sudo docker system prune --all --force - name: Restore dependencies id: restore-cache uses: actions/cache/restore@v4 @@ -36,7 +40,7 @@ jobs: ~/.cargo ~/go ~/target - key: ${{ runner.os }}-cache-osmosis-${{github.sha}} + key: ${{ runner.os }}-cache-osmosis-${{ github.sha }} restore-keys: ${{ runner.os }}-cache-osmosis - name: Update PATH run: echo "$HOME/.cargo/bin" >> $GITHUB_PATH @@ -75,7 +79,7 @@ jobs: PROPTEST_CASES: 10 working-directory: smart-contracts/osmosis/contracts/cl-vault - name: Store dependencies - if: ${{ (inputs.store_deps) && (steps.restore-cache.outputs.cache-hit == false) }}$ + if: inputs.store_deps && !(steps.restore-cache.outputs.cache-hit == 'false') uses: actions/cache/save@v4 with: path: | @@ -83,5 +87,5 @@ jobs: ~/.cargo ~/go ~/target - key: ${{ runner.os }}-cache-osmosis-${{github.sha}} + key: ${{ runner.os }}-cache-osmosis-${{ github.sha }} diff --git a/.github/workflows/cargo_build_cache.yml b/.github/workflows/cargo_build_cache.yml index 1921ab46b..1d1b107cc 100644 --- a/.github/workflows/cargo_build_cache.yml +++ b/.github/workflows/cargo_build_cache.yml @@ -7,6 +7,9 @@ on: required: true type: string +env: + CARGO_TARGET_DIR: ~/target + jobs: store-build-cache: runs-on: ubuntu-latest @@ -22,11 +25,11 @@ jobs: ~/.cache/cachepot ~/.cargo ~/go - smart-contracts/${{ inputs.workspace }}/**/target + ~/target key: ${{ runner.os }}-cargo-${{ inputs.workspace }}-${{github.sha}} restore-keys: ${{ runner.os }}-cargo-${{ inputs.workspace }} - name: Install cachepot - run: test -e $HOME/.cargo/bin/cachepot && echo "cachepot found -- skipping install" || cargo install --git https://github.com/paritytech/cachepot + run: test -e ~/.cargo/bin/cachepot && echo "cachepot found -- skipping install" || cargo install --git https://github.com/paritytech/cachepot - name: Rust check run: cargo check --all-targets --features test-tube working-directory: smart-contracts/${{ inputs.workspace }} @@ -39,5 +42,5 @@ jobs: ~/.cache/cachepot ~/.cargo ~/go - smart-contracts/${{ inputs.workspace }}/**/target + ~/target key: ${{ runner.os }}-cargo-${{ inputs.workspace }}-${{github.sha}} diff --git a/.github/workflows/rust_basic.yml b/.github/workflows/rust_basic.yml index 2e5549cdc..b1fc2fd4d 100644 --- a/.github/workflows/rust_basic.yml +++ b/.github/workflows/rust_basic.yml @@ -22,22 +22,13 @@ jobs: uses: actions/checkout@v3 - name: Install Rust uses: dtolnay/rust-toolchain@stable - - name: Restore dependencies - uses: actions/cache/restore@v4 - with: - path: | - ~/.cargo - ~/go - smart-contracts/${{ inputs.workspace }}/**/target - key: ${{ runner.os }}-cargo-${{ inputs.workspace }}-$GITHUB_SHA - restore-keys: ${{ runner.os }}-cargo-${{ inputs.workspace }} - name: Rust lint - run: cargo lint - working-directory: smart-contracts/${{ inputs.workspace }}/${{ inputs.target }} + run: cargo clippy --all-targets -- -D warnings + working-directory: smart-contracts/${{ inputs.workspace }} - name: Rust format check run: cargo fmt --all -- --check working-directory: smart-contracts/${{ inputs.workspace }}/${{ inputs.target }} - - name: Run unit-tests - if: inputs.unit_tests + - if: inputs.unit_tests + name: Run unit-tests run: cargo unit-test working-directory: smart-contracts/${{ inputs.workspace }}/${{ inputs.target }} diff --git a/.github/workflows/test_tube.yml b/.github/workflows/test_tube.yml index 2cb68d52c..b94245b19 100644 --- a/.github/workflows/test_tube.yml +++ b/.github/workflows/test_tube.yml @@ -24,5 +24,9 @@ jobs: uses: ./.github/workflows/all_checks_osmosis.yml if: github.event_name == 'push' with: + unittest: true proptest: true store_deps: true + pre-commit: + uses: ./.github/workflows/all_checks_osmosis.yml + if: github.event_name == 'pull_request'