Do not call get_unique_id if not needed. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_unique_id can cause a performance overhead, so only call if neeeded.
quandyfactory
added a commit
that referenced
this pull request
Dec 10, 2014
Do not call get_unique_id if not needed.
|
Thank you! That is a nice optimization. There is one other place where the code needs to be changed, so after merging this I'll make the other change and push it as version 1.5.7. |
quandyfactory
added a commit
that referenced
this pull request
Dec 10, 2014
…n when it was not needed
|
I just pushed version 1.5.7, which fixes the same issue inside |
|
Phenomenal - thanks! |
|
Thanks again for identifying and fixing the performance issue! Implementing this fix also fixed another outstanding bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a big performance hit from the get_unique_id method, and didn't need it, so moved it to only need as required.