Posted Comment gets lost if commented answer is converted to comment meanwhile

[q2apro]

Reproduce:

1. Write Answer.
2. Write Comment, but do not submit yet.
3. New browser window: Convert answer to comment.
4. Go back to main window: Submit comment.

Result: Submitted comment is not saved. Instead it gets lost.

[arjunsuresh]

What should ideally happen here?

[q2apro]

Since it is an AJAX post, it is taking effect in qa-include\ajax\comment.php:

 $parentid = qa_post_text('c_parentid'); 

After the A-to-C-conversion is done, this is providing the wrong parentid. It refers to a comment now (which was the former answer).

I tried to fix it with:

if (@$parent['basetype'] == 'C')
{
	$parentid = $parent['parentid'];
	$parent = qa_db_single_select(qa_db_full_post_selectspec($userid, $parentid));
	$children = qa_db_single_select(qa_db_full_child_posts_selectspec($userid, $parentid));
}

but it does not work.

[arjunsuresh]

I think Q2A core doesn't make a comment as a parent as of 1.8.5. So, to fix this won't be a straight forward task. Some hacky way might be required.

[q2apro]

The fix above would be correct (basetype is C in this exceptional case). But I have found the reason, why it does not work in the further code:

With changing the $parent the basetype is "Q" and the code in the if block is executed. However:

The AJAX call is processed from qa-include/ajax/comment.php and triggers this function:

$commentid = qa_page_q_add_c_submit($question, $parent, $children, $usecaptcha, $in, $errors);

function qa_page_q_add_c_submit() you find in qa-include/pages/question-submit.php. There, the script fails at this line:

	if (!qa_check_form_security_code('comment-' . $parent['postid'], qa_post_text($prefix . 'code')))

Because the form security code is not the same anymore as set fronted with the (former) Answer. Now the $parent is the Q with the hack above.