-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in multimodal_datasets.rst #1787
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1787
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ea5b906 with merge base 54673b7 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@RdoubleA You can merge(typo fix) |
@@ -45,7 +45,7 @@ in the text, ``"<image>"`` for where to place the image tokens. This will get re | |||
from torchtune.models.llama3_2_vision import llama3_2_vision_transform | |||
from torchtune.datasets.multimodal import multimodal_chat_dataset | |||
|
|||
transform = Llama3VisionTransform( | |||
model_transform = Llama3VisionTransform( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a line below that still uses transform:
print(transform.decode(tokenized_dict["tokens"], skip_special_tokens=False))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this line, thank you!
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
#1786
Changelog
What are the changes made in this PR?
*
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example