-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets overview docs #1668
Datasets overview docs #1668
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1668
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fac48e8 with merge base 7c59516 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
||
1. Raw data is queried one sample at a time from a Hugging Face dataset, local file, or remote file | ||
2. :ref:`message_transform_usage_label` convert the raw sample which can take any format into a list of torchtune | ||
:ref:`message_usage_label`. Images are contained in the message object they are associated with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of "Images" here say "Media"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Approving so you can land after you fix the docs build.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
*
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example