Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding additional logging to the converter registry system #3199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: adding additional logging to the converter registry system #3199

wants to merge 1 commit into from

Conversation

narendasan
Copy link
Collaborator

Description

Improves the logging in the converter registry

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@narendasan narendasan requested a review from peri044 October 1, 2024 22:14
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Oct 1, 2024
peri044
peri044 reviewed Oct 4, 2024
View reviewed changes
py/torch_tensorrt/dynamo/conversion/impl/__init__.py Outdated
@@ -34,3 +32,4 @@
unsqueeze,
upsample,
)
from torch_tensorrt.fx.converters.impl import convolution
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dynamo.converters

@peri044
Copy link
Collaborator

peri044 commented Nov 18, 2024

@narendasan Will there be additional updates to this or is this good ?

@narendasan narendasan force-pushed the better_converter_registry_logging branch from ffaeeae to 34040d1 Compare November 21, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 left review comments

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narendasan @peri044 @facebook-github-bot