Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party tests failed on Sat Jul 01 2023 #261

Closed
github-actions bot opened this issue Jul 1, 2023 · 6 comments
Closed

Third-party tests failed on Sat Jul 01 2023 #261

github-actions bot opened this issue Jul 1, 2023 · 6 comments

Comments

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Runs listed here: https://github.com/python/typing_extensions/actions/workflows/third_party.yml

@JelleZijlstra
Copy link
Member

Seems like pydantic locked typing-extensions<4.7 for PyPy

🔒 Lock failed
Unable to find a resolution for typing-extensions
because of the following conflicts:
  typing-extensions @ {root:uri}/typing-extensions-latest (from project)
  typing-extensions<4.7.0,>=4.6.0; platform_python_implementation == "PyPy" 
(from [email protected])
  typing-extensions>=4.6.0; platform_python_implementation != "PyPy" (from 
[email protected])
To fix this, you could loosen the dependency version constraints in 
pyproject.toml. See 
https://pdm.fming.dev/latest/usage/dependency/#solve-the-locking-failure for 
more details.

@A5rocks
Copy link

A5rocks commented Jul 1, 2023

Specifically under their pydantic-core package: here's the PR: pydantic/pydantic-core#716.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jul 1, 2023

Not sure I understand why this is also making the pydantic CI runs using CPython fail, as well as the pydantic CI runs using PyPy

@AlexWaygood
Copy link
Member

If we cut 4.7.1 with #262 or a different fix for #258, I can file a PR with pydantic for them to loosen their typing_extensions pin

@AlexWaygood
Copy link
Member

This should hopefully have been fixed by pydantic/pydantic-core#728, but the pydantic jobs on the nightly workflow will continue to fail until they (1) cut a new release of pydantic-core and (2) update the pydantic-core pin in pydantic.

Pydantic-core releases seem to come every few days, though, so this hopefully shouldn't take too long.

@AlexWaygood
Copy link
Member

The workflow now passes again on my GitHub fork following pydantic/pydantic@ab7f805; seems this is now fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants