Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry example installation of pendulum is at this moment not usable for Python 3.12 #8648

Closed
gerrit-ganthor opened this issue Nov 10, 2023 · 4 comments
Labels
area/docs Documentation issues/improvements

Comments

@gerrit-ganthor
Copy link

gerrit-ganthor commented Nov 10, 2023

  • [x ] I have searched the issues of this repo and believe that this is not a duplicate.

Issue

Distutils is removed form Python 3.12.0. This makes your pendulum example in the documentation unusable.
The pendulum developer(s?) plans to correct this in V3.0. See python-pendulum/pendulum#696
I have tested this with:
poetry add "pendulum>=3.0.0b1"

The installation functions, a temporary update of the documentation could help other developers that want to try out poetry.

Minimal TOML files to reproduce this problem:
https://gist.github.com/gerrit-ganthor/39ee891668e2c2a74e2624b04fb77c0d

@gerrit-ganthor gerrit-ganthor added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Nov 10, 2023
@gerrit-ganthor
Copy link
Author

IMHO this is the best place to change this: https://python-poetry.org/docs/basic-usage/#specifying-dependencies
Specify a second entry for the dependency section if Python >= 3.12.0.

[tool.poetry.dependencies]
pendulum = "^3.0.0b1"

@Secrus
Copy link
Member

Secrus commented Nov 29, 2023

I don't think it really matters, that is just an example. If you think it's worth changing it, submit a merge request.

@abn
Copy link
Member

abn commented Mar 2, 2024

I agree with @Secrus. Happy to accept a PR with suggestions. Closing this for now, but updates to docs via PRs getting it current with versions are always welcome.

@abn abn closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2024
@abn abn removed the status/triage This issue needs to be triaged label Mar 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

No branches or pull requests

3 participants