Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flexibility of unit tests with regards to Python versions available in poetry.core #8396

Closed
2 tasks done
jakob-keller opened this issue Sep 1, 2023 · 1 comment · Fixed by #8397
Closed
2 tasks done
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@jakob-keller
Copy link
Contributor

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

As new Python versions are released, poetry-core needs to be updated to surface them, e.g. in automatically added PyPI trove classifiers (#8375).

This process is tedious due to rigid unit tests in poetry that are run as downstream tests by the poetry-core CI pipeline. Specifically, the tests fail in poetry-core when updating available python versions (python-poetry/poetry-core#631). Adjusting those tests in poetry fails since poetry-core has not been prepared accordingly (#8376).

@radoering proposed the following solution:

I tend to think that we should make these tests more generic so we avoid the dance for each new Python version:
We could change the expectation in the tests to all Python versions in Package.AVAILABLE_PYTHONS that are allowed by the test's Python constraint.

Originally posted by @radoering in #8376 (comment)

I will prepare a PR to address this.

@jakob-keller jakob-keller added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Sep 1, 2023
@jakob-keller jakob-keller changed the title Improve flexibility of unit tests with regards to Python versions supported by poetry.core Improve flexibility of unit tests with regards to Python versions available in poetry.core Sep 1, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant