-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in resolve_types with subclasses #843
Conversation
Does this type of change need a changelog entry? |
c517a70
to
daa11e2
Compare
Thanks for stepping up real quick as usual! Yeah I think it’s worth mentioning! For every bug report there’s 10 people who didn’t bother. also pls |
7ad9826
to
e826b4c
Compare
Ok. Gotta go make breakfast but I'll get the changelog in after that. |
Oh god why is codecov angry. If you don’t have time for it, I’ll check once I’m back from Italy and off phone-only. |
Oh it's because nothing tests the "cached" flow. |
Sorry for all the lint failures. I don't have python 3.10 on my machine and you can only run pre-commit or tox -e lint if you have python 3.10. |
Ok I have no idea why codecov is complainign about this: https://app.codecov.io/gh/python-attrs/attrs/compare/843/tree/src/attr/_compat.py |
It was complaining about the same thing on #840 and then magically stopped…some codecov flakiness? :-/ |
It passed! |
🤡 |
Thanks for the quick turnarounds! |
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do. If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.
Fixes #842
.pyi
).tests/typing_example.py
.docs/api.rst
by hand.@attr.s()
have to be added by hand too.versionadded
,versionchanged
, ordeprecated
directives. Find the appropriate next version in our__init__.py
file..rst
files is written using semantic newlines.changelog.d
.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!