Make zope
a semi-optional test dependency
#685
Merged
+39
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the admittedly small number of people who don't care about support for
zope.interface
, it is unnecessary extra work to support even a test-only dependency onzope
.The
zope
-specific tests are relatively contained, however, and with judicious use of pytest fixtures, we can make it so thatzope
is not a required dependency when skipping tests marked withpytest.mark.zope
.This allows users to test everything but the
zope
-specific tests with nozope
dependency with:I realize that this is unusual and maybe not a maintenance burden you want to carry upstream, but it would smooth the process of importing
attrs
upstream into a certain large company's monorepo... I'm fine with a response that's basically "Enough with your weird nonsense, Paul".I didn't bother with documentation or a news fragment yet because I figured there's a high likelihood that this wouldn't be accepted.
Pull Request Check List
changelog.d
.