Add on_setattr hooks to attr.s and attr.ib #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2020
Closed
euresti
reviewed
Jul 10, 2020
Signed-off-by: Hynek Schlawack <[email protected]>
DISABLE sounds less purposeful and doesn't convey its meaning as well.
|
Since there was no more feedback, I'm YOLO-timeouting this. If someone wants to chime in before the release feel free. |
euresti
reviewed
Jul 20, 2020
|
Hi @hynek, I wonder if we have any release plan for this fix? We're having some use-cases which requires this and we're eagerly looking for it to be released. If anything we can help to make it release sooner, can you let us know? |
|
#666 is the last remaining part of the puzzle. I hope I’ll be able to release this week. |
|
Sounds great, thanks so much @hynek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #645 and a billion other issues that asked for freezing attributes and validation on assignment.
I'm not married to all the names and open to better suggestions.
Yes, it was more work to integrate than anticipated. 😳
While working on this I've also noticed that we take no precaution about
__setattr__being inherited, which means that if you subclass a frozen class, you can't easily thaw it. This topic is somewhat related to this PR too but I didn't want to bloat it any further. It goes down to setting__setattr__toobject.__setattr__if we don't write an own, but ifauto_detectis true, only if the user didn't write one?