Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially drop Python 3.4 #608

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Officially drop Python 3.4 #608

merged 1 commit into from
Jan 6, 2020

Conversation

hynek
Copy link
Member

@hynek hynek commented Jan 6, 2020

AP dropped it and there's really no reason to support it anymore. Xenial is on 3.5.

@hynek hynek merged commit 4959682 into master Jan 6, 2020
@hynek hynek deleted the kill-3.4 branch January 6, 2020 11:32
@henryiii
Copy link

But we don’t test it anymore and will block it once someone reports breakage.

If you are using python_requires, this is the wrong way to use it. If you wait till it's broken then update python_requires, pip install attrs will remain broken forever after in that version of Python. It's better to do what NumPy, etc. do, and make a clean break while it is still working, so that pip install will keep working, just installing a known working version of Python. (Now, some of the old versions of Python don't have a new enough pip to do this, and if you are referring to setup.py triggering a block, that's fine).

@hynek
Copy link
Member Author

hynek commented Dec 30, 2020

Yes, that's true.

I'll try to find a way to run the test suite against 3.4 before releasing and the do or don't add the metadat. I guess I'll be able to concoct something with Docker (3.4 doesn't work on macOS anymore).

@henryiii
Copy link

GHA recently added 3.0-3.4 for setup-python@v2, and of course there’s docker. I’m on Big Sur now so need Docker now for anything before about 3.8 anyway. :/

jgosmann added a commit to jgosmann/attrs that referenced this pull request May 6, 2021
Python 3.4 testing has been dropped in python-attrs#608, but it was not declared as
incompatible in setup.py because the code base was expected to still
work with Python 3.4 for a while. This compatibility finally broke with
the 21.1.0 release. At least one of the problematic commits is
e09b1d6 introducing an import of
the typing module not available in Python 3.4.
hynek pushed a commit that referenced this pull request May 6, 2021
Python 3.4 testing has been dropped in #608, but it was not declared as
incompatible in setup.py because the code base was expected to still
work with Python 3.4 for a while. This compatibility finally broke with
the 21.1.0 release. At least one of the problematic commits is
e09b1d6 introducing an import of
the typing module not available in Python 3.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants