Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added first doc stub #506

Merged
merged 5 commits into from
Mar 6, 2020
Merged

added first doc stub #506

merged 5 commits into from
Mar 6, 2020

Conversation

chobeat
Copy link
Contributor

@chobeat chobeat commented Feb 18, 2019

No description provided.

@hynek
Copy link
Member

hynek commented Feb 19, 2019

So the first steps would be:

  1. update your branch to latest master (you can press the button above and pull)
  2. make sure the CI passes. :) you can usually make that sure locally by running tox.

You may want to give another look to our contributing help file since it has a bunch of valuable information that will save you a lot of time!

@chobeat chobeat force-pushed the feat/class_docstrings branch from 17d572e to 4533269 Compare February 19, 2019 13:26
@chobeat
Copy link
Contributor Author

chobeat commented Feb 19, 2019

@hynek now the test passes but it's trivial stuff so far. From the other thread on the issue we left open the discussion on how to proceed from here.

hynek
hynek requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what I noted inline, please add a newsfragment as explained here.

tests/test_make.py Show resolved Hide resolved
tests/test_make.py Outdated Show resolved Hide resolved
tests/test_make.py Outdated Show resolved Hide resolved
src/attr/_make.py Outdated Show resolved Hide resolved
tests/test_make.py Show resolved Hide resolved
@chobeat chobeat force-pushed the feat/class_docstrings branch from 55b886a to 633107f Compare March 8, 2019 23:03
@chobeat
Copy link
Contributor Author

chobeat commented Mar 10, 2019

I've added the newsfragment and I've addressed most of the points. When you answer in the open conversations I can proceed.

@hynek
Copy link
Member

hynek commented Mar 6, 2020

Sorry I dropped the ball on this, could you resolve the conflicts please?

@hynek hynek added this to the 20.1.0 milestone Mar 6, 2020
@chobeat chobeat force-pushed the feat/class_docstrings branch from 217f183 to b4326af Compare March 6, 2020 11:11
@hynek hynek merged commit 4dea97e into python-attrs:master Mar 6, 2020
@hynek
Copy link
Member

hynek commented Mar 6, 2020

Thanks and sorry for the delays!

@domdfcoding
Copy link

Is this the solution to #492?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hynek hynek hynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chobeat @hynek @domdfcoding @srobuttiteraki