Introduce NothingType #1358
Merged
Introduce NothingType #1358
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinche
force-pushed
the
tin/fix-nothing
branch
from
668dcd1 to
58246be
Compare
|
I presume this is based on https://discuss.python.org/t/do-we-need-a-valuealias-in-addition-to-typealias/67609? I guess it needs some docs and a changelog entry? |
|
nudge |
4 tasks
Tinche
force-pushed
the
tin/fix-nothing
branch
from
e74d70f to
e158df9
Compare
|
Is there any chance at all to test this?? |
Tinche
force-pushed
the
tin/fix-nothing
branch
2 times, most recently
from
ad225bc to
ae4c51d
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Tinche
force-pushed
the
tin/fix-nothing
branch
from
ae4c51d to
3357aab
Compare
hynek
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I introduced NothingType, but from what I can tell we're not using this anywhere? This is solely for the benefit of third parties annotating their code to accept NOTHING?