Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError for asdict(<class with namedtuple>, retain_collection_types=True) #1165

Merged
merged 27 commits into from
Jul 29, 2023

Conversation

kwist-sgr
Copy link
Contributor

@kwist-sgr kwist-sgr commented Jul 19, 2023

Summary

Pull Request Check List

  • Added tests for changed code.
    Our CI fails if coverage is not 100%.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
    • If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      The next version is the second number in the current release + 1.
      The first number represents the current year.
      So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
      If the next version is the first in the new year, it'll be 23.1.0.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

Resolves #1164

@kwist-sgr kwist-sgr changed the title Fix TypeError for asdict with namedtuples and retain_collection_types=True Fix TypeError for asdict(<class with namedtuple>, retain_collection_types=True) Jul 20, 2023
@kwist-sgr kwist-sgr changed the title Fix TypeError for asdict(<class with namedtuple>, retain_collection_types=True) Fix TypeError for asdict(<class with namedtuple>, retain_collection_types=True) (#1164) Jul 20, 2023
@kwist-sgr kwist-sgr changed the title Fix TypeError for asdict(<class with namedtuple>, retain_collection_types=True) (#1164) Fix TypeError for asdict(<class with namedtuple>, retain_collection_types=True) Jul 20, 2023
@kwist-sgr kwist-sgr requested a review from hynek July 27, 2023 09:40
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've fixed some stylistic issues, let's see what the CI has to say.

tests/test_funcs.py Outdated Show resolved Hide resolved
tests/test_funcs.py Outdated Show resolved Hide resolved
tests/test_funcs.py Outdated Show resolved Hide resolved
tests/test_funcs.py Outdated Show resolved Hide resolved
tests/test_funcs.py Outdated Show resolved Hide resolved
Comment on lines 456 to 457
instance = A(Coordinates(50.419019, 30.516225))
assert (Coordinates(50.419019, 30.516225),) == attr.astuple(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
instance = A(Coordinates(50.419019, 30.516225))
assert (Coordinates(50.419019, 30.516225),) == attr.astuple(
instance = A(Coordinates(50.419019, 30.516225))
assert (Coordinates(50.419019, 30.516225),) == attr.astuple(

tests/test_funcs.py Outdated Show resolved Hide resolved
tests/test_funcs.py Outdated Show resolved Hide resolved
changelog.d/1165.change.md Outdated Show resolved Hide resolved
src/attr/_funcs.py Show resolved Hide resolved
@kwist-sgr
Copy link
Contributor Author

Sure 👍

@hynek hynek enabled auto-merge (squash) July 29, 2023 19:26
@hynek hynek merged commit 0bf0678 into python-attrs:main Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamedTuple serialization fails to work
2 participants