Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate zope-interface support #1120

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Deprecate zope-interface support #1120

merged 4 commits into from
Apr 10, 2023

Conversation

hynek
Copy link
Member

@hynek hynek commented Apr 5, 2023

It's a C-based dependency for a dozen of lines of code.

If there's interest, we can publish it as a separate package.

@hynek hynek requested a review from pganssle April 5, 2023 07:08
hynek added 2 commits April 5, 2023 10:42
It's a C-based dependency for a dozen of lines of code.

If there's interest, we can publish it as a separate package.
@chrysle
Copy link
Contributor

chrysle commented Apr 6, 2023

Why, that's quite a lot being deprecated in or after april 2024! How do you keep track?

@hynek
Copy link
Member Author

hynek commented Apr 10, 2023

I don’t. :D

Things get usually removed when you stumble over deprecated code while trying to do something else. I guess there’s not that much of a downside to remove deprecated code later.

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. My main involvement with this was that we don't use it but it was annoying to package zope just to run the attrs tests. The current situation, where zope is an optional test dependency, works perfectly for our purposes, but I think that droping mainline support for zope and moving it to a third-party package if there's interest is a good, and probably more sustainable approach in the long term.

@hynek hynek merged commit c8b342d into main Apr 10, 2023
@hynek hynek deleted the deprecate-zi branch April 10, 2023 13:34
@itamarst
Copy link

itamarst commented Jul 3, 2023

Tahoe-LAFS is using this, but I'm not sure it's worth your time to package this separately—we could just copy/paste the relevant code into the codebase with appropriate license/attribution? Or I guess since we're using mypy-zope just rely on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants