Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port topomodelx/transforms (dev branch) to toponetx #34

Open
1 of 4 tasks
ninamiolane opened this issue May 12, 2023 · 0 comments
Open
1 of 4 tasks

Port topomodelx/transforms (dev branch) to toponetx #34

ninamiolane opened this issue May 12, 2023 · 0 comments
Assignees
Labels

Comments

@ninamiolane
Copy link
Collaborator

ninamiolane commented May 12, 2023

What?

Put code that lifts a complex (such as a simplicial complex) into another (such as a cellular complex) into toponetx.

This code is currently in topomodelx/transforms (dev branch) here.

Why?

Because the lift operation can be used outside of the deep learning context.
Thus, it should be removed from topomodelx and included in toponetx.

Where?

Into a folder TopoNetX/toponetx/lift and files:

  • to_hypergraph.py
  • etc

With a corresponding folder of tests in TopoNetX/test/lift and files:

  • test_to_hypergraph.py
  • etc

How?

Only integrate a new function into toponetx if it comes with its corresponding test function.

@ninamiolane ninamiolane changed the title Put code from topomodelx/transforms (dev branch) into toponetx Port topomodelx/transforms (dev branch) to toponetx May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants