-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distutils.sysconfig directory returns Makefile relative to venv #1783
Comments
The issue seems to be how A naive solution seems to be to also copy all the files that |
I would definitely want to avoid that solution. It caused a lot of issues in virtualenv less than 20, bugs we managed to close by not doing that. |
Apologies, I am new here. For issues like this, what has been the general consensus for solving them post rewrite? |
Generally, it's a decision of the project maintainers, I'm at the moment the primary person at the moment. Will look into this and propose alternative searched; at the moment if at all possible I'd like to avoid copying stuff. Maybe we can just link/copy in that make file to exist within the venv too; but let's see if there are better solutions. |
Fixed via #1787 |
Hello, this now has been released via https://pypi.org/project/virtualenv/20.0.19/ |
Issue
Starting in virtualenv 20.0.5 the path to the sysconfig directory changed to be relative to the virtualenv. Prior to 20.0.5
distutils.sysconfig.get_makefile_filename()
returned the Makefile in the master Python install. Since 20.0.5 it returnsvenv/lib/python2.7/config/Makefile
which does not exist.This is an issue for programs which try to read/parse the non-existent Makefile. For example, numpy 1.16.x install fails see line at URL below
https://github.com/numpy/numpy/blob/12daed78eecbacdb35b49335f061b2437f019f0f/numpy/distutils/fcompiler/gnu.py#L142
The following is a simple program to demonstrate the issue. In 20.0.4 a path to an existing Makefile is returned. From 20.0.5 the path returned does not exist.
Environment Follows
Python
OS
pip list
Output of virtual environment creation
The text was updated successfully, but these errors were encountered: