Support entry point paths with spaces #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
force-pushed
the
fix_entry_points_with_spaces
branch
from
db31ef5 to
fed246e
Compare
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Feb 25, 2020
Also: - Fix integration tests for checkout@v2 action: the working directory is not updated any more when `path` is specified - Use checkout action to clone the galaxy-test-data repo and rsync to move them in place - Install virtualenv<20 when running tests via tox in a directory containing spaces, xref. pypa/virtualenv#1660
gaborbernat
reviewed
Feb 25, 2020
gaborbernat
force-pushed
the
fix_entry_points_with_spaces
branch
from
0ed3dac to
c52b376
Compare
Before this patch: ```console $ virtualenv --version virtualenv 20.0.6.dev5+g9201422 from /usr/users/ga002/soranzon/software/nsoranzo_virtualenv/.venv/local/lib/python2.7/site-packages/virtualenv/__init__.pyc $ virtualenv 'foo bar' created virtual environment CPython2.7.17.final.0-64 in 403ms creator CPython2Posix(dest=/usr/users/ga002/soranzon/software/nsoranzo_virtualenv/foo bar, clear=False, global=False) seeder FromAppData(download=False, pip=latest, setuptools=latest, wheel=latest, via=copy, app_data_dir=/usr/users/ga002/soranzon/.local/share/virtualenv/seed-v1) activators PythonActivator,CShellActivator,FishActivator,PowerShellActivator,BashActivator $ head -n 3 foo\ bar/bin/pip #!/bin/sh '''exec' /usr/users/ga002/soranzon/software/nsoranzo_virtualenv/foo bar/bin/python "$0" "$@" ' ''' $ ./foo\ bar/bin/pip ./foo bar/bin/pip: 2: exec: /usr/users/ga002/soranzon/software/nsoranzo_virtualenv/foo: not found ``` After this patch: ```console $ virtualenv 'foo bar' created virtual environment CPython2.7.17.final.0-64 in 336ms creator CPython2Posix(dest=/usr/users/ga002/soranzon/software/nsoranzo_virtualenv/foo bar, clear=False, global=False) seeder FromAppData(download=False, pip=latest, setuptools=latest, wheel=latest, via=copy, app_data_dir=/usr/users/ga002/soranzon/.local/share/virtualenv/seed-v1) activators PythonActivator,CShellActivator,FishActivator,PowerShellActivator,BashActivator $ head -n 3 foo\ bar/bin/pip #!/bin/sh '''exec' "/usr/users/ga002/soranzon/software/nsoranzo_virtualenv/foo bar/bin/python" "$0" "$@" ' ''' $ ./foo\ bar/bin/pip Usage: pip <command> [options] ... ```
Signed-off-by: Bernat Gabor <[email protected]>
Signed-off-by: Bernat Gabor <[email protected]>
gaborbernat
force-pushed
the
fix_entry_points_with_spaces
branch
from
c52b376 to
8f3d8d2
Compare
gaborbernat
changed the title
nsoranzo
changed the title
|
Hello, a fix for this issue has been released via virtualenv 20.0.6; see https://pypi.org/project/virtualenv/20.0.6/ (https://virtualenv.pypa.io/en/latest/changelog.html#v20-0-6-2020-02-26) . Please give a try and report back if your issue has not been addressed; if not, please comment here, and we'll reopen the ticket. We want to apologize for the inconvenience this has caused you and say thanks for having patience while we resolve the unexpected bugs with this new major release. |
|
I am experiencing this issue in version 20.14.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch:
After this patch:
N.B.: virtualenv <20 was also quoting the path and therefore did not have the issue.
Thanks for contributing a pull request, see checklist all is good!
docs/changelogfolder