Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower min version of six to 1.9 #1606

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Lower min version of six to 1.9 #1606

merged 1 commit into from
Feb 13, 2020

Conversation

ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Feb 13, 2020 •
edited
Loading

This change should allow installation of virtualenv on systems with older six where their LTS support may prevent them from upgrading it.

Fixes: #1605

@ssbarnea ssbarnea force-pushed the master branch 2 times, most recently from 94fdcab to ac1730e Compare February 13, 2020 13:03
@ssbarnea ssbarnea changed the title POC: Lower minversion of six Lower min version of six to 1.9 Feb 13, 2020
@ssbarnea ssbarnea marked this pull request as ready for review February 13, 2020 13:26
@ssbarnea ssbarnea requested a review from gaborbernat February 13, 2020 13:26
gaborbernat
gaborbernat requested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep imports as it is, and only move the ensure_text and ensure_str to our virtualenv.util.six package 👍

@ssbarnea ssbarnea requested a review from gaborbernat February 13, 2020 15:03
@gaborbernat
Copy link
Contributor

Let's keep all import from six other than the two ensure Which can be from virtualenv.util 🤷‍♂️

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Feb 13, 2020 •
edited
Loading

Let's keep all import from six other than the two ensure Which can be from virtualenv.util 🤷‍♂️

Done another round, metaclass was not really needed, lets check again after it reports green.

@ssbarnea
Lower min version of six required
05a74d5 
This change should allow installation of virtualenv on systems
with older six where their LTS support may prevent them from
upgrading it.
@ssbarnea
Copy link
Contributor Author

AFAIK, i am done, now waiting for @gaborbernat to look again at this boring change.

@gaborbernat gaborbernat merged commit 52e4213 into pypa:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

virtualenv should lower deps on six to six>=1.9.0
2 participants
@ssbarnea @gaborbernat