-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a virtualenv gives no feedback to user #1557
Comments
Has been commented during the beta that some people like the silent out of box behaviour, similarly how the rm command does not print just does. If you pass in a -v you'll get more feedback. I'm split between the current behaviour and maybe a one line final report 🤔on success. If you'd have warning/errors during the creation those you would already see. |
The behaviour of "silent" shell commands is counter-intuitive and needs to be explained to new users, in my experience as Software Carpentry instructor. In virtualenv case, passing from giving feedback to be silent is even more surprising. |
As someone who said I liked the new quieter behaviour, I will note that I didn't realise that you could omit even the name of the environment (the So, my preference now would be one or both of:
We could also bikeshed endlessly over the "correct" default for |
IMHO having it as .venv gives a false impression is a private/hidden, which is not the case (we learned this the hard way in tox). I'd personally would be an advocate of 2, without 1. |
That's not my ideal, but it works for me. (Arguing over the default name was meant as a joke, by the way). |
I'm ok with option 1 too 👍 if both you and @pradyunsg advocate for it 🤷♂ |
On board for making |
If I have to choose, I'd prefer 2), i.e. to have this issue addressed, but preferably both. |
@nzoranzo we fixed both. :) |
Perfect, thanks! |
Hello, a fix for this issue has been released via virtualenv 20.0.2; see https://pypi.org/project/virtualenv/20.0.2/ (https://virtualenv.pypa.io/en/latest/changelog.html#v20-0-2-2020-02-11) . Please give a try and report back if your issue has not been addressed; if not, please comment here, and we'll reopen the ticket. We want to apologize for the inconvenience this has caused you and say thanks for having patience while we resolve the unexpected bugs with this new major release. |
Behaviour pre v20:
New behaviour in v20.0.1:
It doesn't need to print the same messages of course, but at least something!
It is especially surprising in the case of running just
virtualenv
, which before was printing the help and returning an error code because of the missingDEST_DIR
, while now creates a virtualenv in the new defaultvenv
and returns 0 without any feedback.The text was updated successfully, but these errors were encountered: