-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip wheel -> pip wheelhouse #6817
Comments
Generally I'm -1 on this. The benefit is minimal, and the cost in terms of breaking people's automated workflows/scripts doesn't seem worth it. But there's no harm in exploring the idea - I just think it'll be hard to justify. |
To be clear, if we even do this, it'd likely have a long deprecation period. I'm, myself, not sure how good an idea this is but I also didn't feel like I should just dismiss this as a bad idea immediately. |
:-P Yeah, I'm probably being a bit too quick to dismiss the idea... It's more likely (in my mind) to make sense as part of a wider review of the structure of pip's subcommands, though. |
Renaming the command while keeping "wheel" as a compatibility alias forever should give most of the gain with little of the pain. |
Well, my reservation is more about the idea that the command is for making a wheelhouse. Normally when I use If we're renaming commands, I'd rather we looked at use cases and designed a command structure to satisfy those use cases, hence my comment about a wider review. Basically my personal use cases match (in my head, at least!) a |
@pfmoore I'd say if we have the build UI for end users, the "build a single wheel" use case is covered there. IIUC, it only leaves us with "build a wheelhouse", which is what pip wheel defaults to. |
OK, so I just tried thinking through how my typical use cases correspond with And my conclusion is that it's really complicated. (No surprise, UI design usually is). But I am 100% sure that none of my use cases feel like So there's a lot of compromises needed here if we don't want to end up with too many nearly-the-same commands, or too many options that change what a command conceptually does. Which is why I say we should look at the wider picture, rather than treating this as a tactical fix. I don't think there's a rush on this, and I do think it's only a small part of a bigger picture. This is probably something that would be better handled as part of the pip UX work that the packaging WG is seeking funding for. |
Isn't cheese stored in cellars? |
A wheelhouse is an enclosed room used to steer a boat. I used to like the word wheelbase which means the distance between the wheels on a carriage. But they do not really make sense as a place to store wheels. IMO there's nothing wrong with using wheel as a verb in pip. |
Yea. I concur with you. It'll probably help if we list what use cases we're thinking of, for the UX expert coming in later, as well as us now when we're discussing. |
I've added this to the list of tickets to research as part of #8516.
Yes, it would! Please share use cases :) |
Closing this out, since I don't think this is worthwhile anymore. |
pip wheel has semantics that are relevant when you're trying to build a "wheelhouse" --> a self-contained set of wheels that can be used to install a few packages.
It might be worth it to rename the command. This is, of course, dependent on how #6041 goes but filing a new issue to keep track that this might be an avenue worth exploring regardless.
The text was updated successfully, but these errors were encountered: