-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a mechanism to query keyring for credentials in combination with --no-input #11020
Comments
If I understand correctly |
Incorrect, assuming Pip is not "the system" but the OS is. If the third party
#11029 is basically that, but with a different name since I do not currently believe "system" should be a part of the name as I hopefully made clear above. I am not married to the name I chose however. |
Is there anything I can do, other than wait for more people to look at #11029, to move this along? (There isn't a group I can ping, and pinging random maintainers seems rude. The development documentation for contributing and issue triage didn't give me a clear answer either.) |
What's the problem this feature will solve?
Currently, Pip is conservative and does not query keyring at all when
--no-input
is used because the keyring might require user interaction such as prompting the user on the console.Tools such as Pipx and Pipenv use Pip and have their own progress indicator that hides output from the subprocess Pip runs in. They should pass
--no-input
in my opinion, but Pip should provide some mechanism to still query the keyring in that case. Just not by default. So here we are.Describe the solution you'd like
A flag to pinky swear that the configured keyring backend does not require any user interaction. It defaults to
False
, making this opt-in behaviour.Alternative Solutions
Hardcoding a Personal Access Token in the index url and then probably wondering why things stopped working when it expires.
Additional context
The three UX situations I encountered that would be improved:
Pipenv passes
--no-input
when resolving, as of 2020.05.29 if I recall correctly, causing locking to fail. Passing--skip-lock
to theinstall
command or using thesync
command lets us install from a Pipfile.lock, but to generate/update a Pipfile.lock we need to hardcode credentials in the url thelock
command uses.I intend to add a PR for Pipx to pass
--no-input
but passing--pip-args="--no-input"
is a workaround that would work if the feature this issue requests is added.app-data
seeder setsPIP_NO_INPUT
to a truthy value when it tries to download newer versions.This is issue for the PR I am working on, for which I need a issue number.
Code of Conduct
The text was updated successfully, but these errors were encountered: