Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minimum requirement for jaraco.functools #300

Open
anderstheet opened this issue Oct 8, 2024 · 0 comments · May be fixed by #301
Open

Use minimum requirement for jaraco.functools #300

anderstheet opened this issue Oct 8, 2024 · 0 comments · May be fixed by #301

Comments

@anderstheet
Copy link

Description

distutils uses a function from jaraco.functools called splat:
https://github.com/pypa/distutils/blob/main/distutils/_modified.py#L6

That function is only available from version 4.x.x. So jaraco.functools should have a minimum requirement:
https://github.com/pypa/setuptools/blob/v75.1.0/pyproject.toml#L106

Expected behavior

Should have a version conflict when installing setuptools in combination with other packages that require jaraco.functools < 4.

How to Reproduce

Install setuptools with another package that require jaraco.functools < 4.

Output

File "/app/xxx.py", line 9, in <module>
  from distutils.util import strtobool
File "/poetry-env/lib/python3.10/site-packages/setuptools/_distutils/util.py", line 23, in <module>
  from ._modified import newer
File "/poetry-env/lib/python3.10/site-packages/setuptools/_distutils/_modified.py", line 6, in <module>
  from jaraco.functools import splat
ImportError: cannot import name 'splat' from 'jaraco.functools' (/poetry-env/lib/python3.10/site-packages/jaraco/functools.py)
@anderstheet anderstheet linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant