-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc generation errors and re-organize examples #914
Conversation
7da0a0f
to
bbc46e0
Compare
I have updated your PR, because a lot of the changes was already done. I have no problem moving the examples back, but then they should be changed to be asyncio only. Please do not forget the idea to move them in the first place, was to get rid of twisted/tornado. Why is it important to have e.g. examples/contrib/tornado_twisted/sunspec_client.py direct in examples ? A compromise could be to let the documentation point at the tornado_twisted directory. |
UPDATE |
Now the doc can be generated here (after a rebase and an extra commit). I will take a closer look now at the files you moved. Sunspec was my bad, I was confused by something else. |
Now I can see that there are missing rst files, let me update that. |
@dhoomakethu Please exclude the examples directory from Sonar, or at the very least remove the check for duplicate code (which is quite normal between examples). |
f288f63
to
00deda8
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
No description provided.