Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include package and tests in coverage measurement #912

Merged
merged 1 commit into from
May 25, 2022

Conversation

altendky
Copy link
Contributor

Related to #598.

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janiversen janiversen merged commit a8da0de into pymodbus-dev:dev May 25, 2022
@altendky
Copy link
Contributor Author

This didn't actually seem to add the tests/ to the report. Sorry, I should have made this a draft PR.

@janiversen
Copy link
Collaborator

hmmm seems I looked wrongly in the CI

@janiversen
Copy link
Collaborator

but also note that the test directory is covered by pylint, codespell, bandit, flake8 and black, so I am not so sure that coverage will find a lot.

@altendky
Copy link
Contributor Author

Do any of those check coverage?

@janiversen
Copy link
Collaborator

not as good as coverage, but pylint detect a number of “dead” code examples.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants