Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter documentation of methods. #909

Merged
merged 1 commit into from
May 28, 2022
Merged

Fix parameter documentation of methods. #909

merged 1 commit into from
May 28, 2022

Conversation

janiversen
Copy link
Collaborator

@janiversen janiversen commented May 22, 2022

This PR correct all missing/false parameter documentations.

At the moment there are circa 800 errors, so I believe it is safe to say that our documentation lack a bit.

I have submitted the PR to raise awareness that I have started on this work, however help is more than welcome.

To see the problems, download this PR "gh pr checkout 909", and run "tox -e pylint".

@janiversen janiversen marked this pull request as draft May 22, 2022 14:32
@janiversen
Copy link
Collaborator Author

@swamper123 This could be something for you, a nice way of getting into the code.

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@janiversen janiversen marked this pull request as ready for review May 27, 2022 17:48
@janiversen janiversen merged commit 4a7dca8 into pymodbus-dev:dev May 28, 2022
@janiversen janiversen deleted the PR_docparams branch May 28, 2022 06:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant