Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove twisted/tornado from doc #904

Merged
merged 1 commit into from
May 24, 2022
Merged

Remove twisted/tornado from doc #904

merged 1 commit into from
May 24, 2022

Conversation

janiversen
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@janiversen
Copy link
Collaborator Author

@dhoomakethu can you please control that I made the changes correctly (I am not sure how to generate doc).

Since you will be doing dev4, lets include this if it works.

@dhoomakethu
Copy link
Contributor

Looks like the documentation build is broken on readthedocs. I will take a stab in to this after Wednesday.
image

@janiversen
Copy link
Collaborator Author

@dhoomakethu can you please confirm, that this PR works now.

Do we somewhere have a HOW_TO document, explaining how to generate and check the documentation, of course only local ?

@dhoomakethu
Copy link
Contributor

make docs should generate the documents locally

@janiversen
Copy link
Collaborator Author

Thanks I will try to do that.

@janiversen janiversen merged commit a957539 into pymodbus-dev:dev May 24, 2022
@janiversen janiversen deleted the PR_doc_cleanup branch May 24, 2022 12:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants