Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to pydmodbus-dev #1291

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Update links to pydmodbus-dev #1291

merged 4 commits into from
Jan 24, 2023

Conversation

alexrudd2
Copy link
Collaborator

  • Rename all links riptideio->pymodbus-dev. This fixes the install issue @aritakku was facing

Tried again, and the installation via instructions does not work:
git clone git://github.com/riptideio/pymodbus.git

Originally posted by @aritakku in #1290 (comment)

  • Add HTML lang attribute to satisfy HTML linters.

README.rst Outdated Show resolved Hide resolved
@janiversen
Copy link
Collaborator

Seems you have a lot of good changes here! let me just do the review.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches!

you have done with lang=en, where my PR was only riptideio --> pymodbus-dev

README.rst Outdated Show resolved Hide resolved
@janiversen janiversen merged commit 59c06b7 into dev Jan 24, 2023
@janiversen janiversen deleted the update-links branch January 24, 2023 19:07
@janiversen
Copy link
Collaborator

Thanks.

alexrudd2 added a commit to alexrudd2/pymodbus that referenced this pull request Feb 21, 2023
Add HTML lang attribute, Update README.rst

Co-authored-by: jan iversen <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants