Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unix sockets parsing #1281

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix Unix sockets parsing #1281

merged 1 commit into from
Jan 24, 2023

Conversation

alexrudd2
Copy link
Collaborator

@peufeu2 found a typo:

tcp.py line 213:
if self.params.host.startswith("unit:"):

"unit" should be "unix", since it's about unix sockets...

Originally posted by @peufeu2 in #1279 (comment)

@alexrudd2 alexrudd2 mentioned this pull request Jan 24, 2023
Merged
@janiversen
Copy link
Collaborator

Now how did that make it onto dev, my fault, I thought I had corrected it.

janiversen
janiversen approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, and thanks for the PR.

@janiversen janiversen merged commit b416b17 into pymodbus-dev:dev Jan 24, 2023
alexrudd2 added a commit to alexrudd2/pymodbus that referenced this pull request Feb 21, 2023
@alexrudd2
Fix Unix sockets parsing (pymodbus-dev#1281)
aa6d8db
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen